feat: add fbc-fips-check task #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only to be merged after #1681 |
yashvardhannanavati
force-pushed
the
new_fbc_fips_check
branch
from
9565a7d to
93a8459
Compare
MartinBasti
previously approved these changes
Dec 10, 2024
yashvardhannanavati
force-pushed
the
new_fbc_fips_check
branch
12 times, most recently
from
743dad7 to
e99738e
Compare
|
@dirgim @arewm Could you please help review this? It is fairly similar to #1681 . It even utilizes the stepAction added in that PR. The only major difference being,
|
|
/ok-to-test |
MartinBasti
previously approved these changes
Dec 18, 2024
yashvardhannanavati
dismissed stale reviews from MartinBasti and dirgim
via
fec23c4
yashvardhannanavati
force-pushed
the
new_fbc_fips_check
branch
from
e99738e to
fec23c4
Compare
Refers to CVP-4334. This task is used to verify FIPS compliance of unreleased bundles in an FBC fragment. FBC fragment provides the target OCP version of the bundle, which enables the task to run check-payload with version specific embedded config. Signed-off-by: Yashvardhan Nanavati <[email protected]>
yashvardhannanavati
force-pushed
the
new_fbc_fips_check
branch
from
fec23c4 to
f887840
Compare
|
@dirgim @MartinBasti apologies, I had to make a minor change to the task. Could you please approve it again? |
chmeliik
approved these changes
Dec 19, 2024
|
/ok-to-test |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Josh-Everett
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to CVP-4334. This task is used to verify FIPS compliance of unreleased bundles in an FBC fragment. FBC fragment provides the target OCP version of the bundle, which enables the task to run check-payload with version specific embedded config.